On Tue, Dec 22, 2020 at 01:17:43PM -0500, Prarit Bhargava wrote: > It seems that cki-bot doesn't like it when I remove the "No CCs" label from an > MR. You can see this odd behaviour in !741: > > https://gitlab.com/cki-project/kernel-ark/-/merge_requests/741 > > I ran a script to identify all the mislabeled "No CCs" MRs, and tried to remove > it by hand from !741. The cki-bot immediately steps in and relabels it. > > Is there some step I'm missing? !741 clearly has CCs. The only thing I can > think of is that cki-bot's webhook is broken. OK, I think I know what the problem is (/me loves the --merge-request hook for webhooks). The public webhooks walks all the commits in the MR. If 1 of them does not have CCs, then it slaps a label on it. In this, Patrick's added patch is missing the CC. Of course he doesn't care because it gets squashed later. But that is what is triggering it. We could change the code to say if at least 1 _has_ a CC, ignore it and move on. Or perhaps we should only look for CCs in the merge log instead of the commit log? The label is specific to changes in 'redhat/configs/[fedora|ark|common]', so perhaps just the merge message is good enough??? Thoughts? Cheers, Don > > P. > _______________________________________________ > kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
