On Tue, 2020-10-20 at 14:50 +0200, Ondrej Mosnacek wrote: > On Tue, Oct 13, 2020 at 9:40 PM GitLab Bridge on behalf of jeremycline > <cki-gitlab@xxxxxxxxxx> wrote: > > From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > > > > Hi, > > > > As part of the ongoing rebase effort, the following configuration > > options need to be reviewed. > > > > As a reminder, the ARK configuration flow involves moving unreviewed > > configuration options from the pending directory to the ark directory. > > In the diff below, options are removed from the pending directory and > > added to the ark hierarchy. The final options that need to be ACKed > > are the files that are being added to the ark hierarchy. > > > > If the value for a file that is added should be changed, please reply > > with a better option. > > > > CONFIG_CRYPTO_SM2: > > > > Generic implementation of the SM2 public key algorithm. It was > > published by State Encryption Management Bureau, China. > > as specified by OSCCA GM/T 0003.1-2012 -- 0003.5-2012. > > > > References: > > https://tools.ietf.org/html/draft-shen-sm2-ecdsa-02 > > http://www.oscca.gov.cn/sca/xxgk/2010-12/17/content_1002386.shtml > > http://www.gmbz.org.cn/main/bzlb.html > > > > Symbol: CRYPTO_SM2 [=n] > > Type : tristate > > Defined at crypto/Kconfig:263 > > Prompt: SM2 algorithm > > Depends on: CRYPTO [=y] > > Location: > > -> Cryptographic API (CRYPTO [=y]) > > Selects: CRYPTO_SM3 [=n] && CRYPTO_AKCIPHER [=y] && CRYPTO_MANAGER [=y] && MPILIB [=y] && ASN1 [=y] > > Looking at the current state of SM* configs in ARK, there seems to be > some disconnect: > > ark/generic/CONFIG_CRYPTO_SM3:# CONFIG_CRYPTO_SM3 is not set > ark/generic/CONFIG_CRYPTO_SM3_ARM64_CE:CONFIG_CRYPTO_SM3_ARM64_CE=m > ark/generic/CONFIG_CRYPTO_SM4:# CONFIG_CRYPTO_SM4 is not set > ark/generic/CONFIG_CRYPTO_SM4_ARM64_CE:CONFIG_CRYPTO_SM4_ARM64_CE=m > ark/generic/arm/aarch64/CONFIG_CRYPTO_SM3_ARM64_CE:# > CONFIG_CRYPTO_SM3_ARM64_CE is not set > ark/generic/arm/aarch64/CONFIG_CRYPTO_SM4:CONFIG_CRYPTO_SM4=m > > Why is CONFIG_CRYPTO_SM4 enabled only on aarch64? Why is > CONFIG_CRYPTO_SM3_ARM64_CE enabled, but CONFIG_CRYPTO_SM3 is not? > These should be consolidated. And shouldn't the *_ARM64_* configs be under generic/arm/aarch64 rather than generic? I don't see a need for CONFIG_CRYPTO_SM4 because all the platforms we care about will have the crypto enhancement (ARM64_CE) insns. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
