On Sat, Oct 17, 2020 at 8:26 AM GitLab Bridge on behalf of jeremycline <cki-gitlab@xxxxxxxxxx> wrote: > From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_ZCRYPT_DEBUG: > > Say 'Y' here to enable some additional debug features on the > s390 cryptographic adapters driver. > > There will be some more sysfs attributes displayed for ap cards > and queues and some flags on crypto requests are interpreted as > debugging messages to force error injection. > > Do not enable on production level kernel build. > > If unsure, say N. > > Symbol: ZCRYPT_DEBUG [=n] > Type : bool > Defined at drivers/crypto/Kconfig:78 > Prompt: Enable debug features for s390 cryptographic adapters > Depends on: CRYPTO [=y] && CRYPTO_HW [=y] && DEBUG_KERNEL [=y] && ZCRYPT [=m] > Location: > -> Cryptographic API (CRYPTO [=y]) > -> Hardware crypto devices (CRYPTO_HW [=y]) > -> Support for s390 cryptographic adapters (ZCRYPT [=m]) > > --- > > Cc: Herbert Xu <herbert.xu@xxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxx> > Cc: Ondrej Mosnacek <omosnace@xxxxxxxxxx> > Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > --- > .../common/generic/CONFIG_ZCRYPT_DEBUG | 1 + > .../generic/CONFIG_ZCRYPT_DEBUG | 26 ------------------- > 2 files changed, 1 insertion(+), 26 deletions(-) > create mode 100644 redhat/configs/common/generic/CONFIG_ZCRYPT_DEBUG > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ZCRYPT_DEBUG > > diff --git a/redhat/configs/common/generic/CONFIG_ZCRYPT_DEBUG b/redhat/configs/common/generic/CONFIG_ZCRYPT_DEBUG > new file mode 100644 > index 000000000000..4e0e29a35496 > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_ZCRYPT_DEBUG > @@ -0,0 +1 @@ > +# CONFIG_ZCRYPT_DEBUG is not set > diff --git a/redhat/configs/pending-common/generic/CONFIG_ZCRYPT_DEBUG b/redhat/configs/pending-common/generic/CONFIG_ZCRYPT_DEBUG > deleted file mode 100644 > index b0a111e75605..000000000000 > --- a/redhat/configs/pending-common/generic/CONFIG_ZCRYPT_DEBUG > +++ /dev/null > @@ -1,26 +0,0 @@ > -# CONFIG_ZCRYPT_DEBUG: > -# > -# Say 'Y' here to enable some additional debug features on the > -# s390 cryptographic adapters driver. > -# > -# There will be some more sysfs attributes displayed for ap cards > -# and queues and some flags on crypto requests are interpreted as > -# debugging messages to force error injection. > -# > -# Do not enable on production level kernel build. > -# > -# If unsure, say N. > -# > -# Symbol: ZCRYPT_DEBUG [=n] > -# Type : bool > -# Defined at drivers/crypto/Kconfig:78 > -# Prompt: Enable debug features for s390 cryptographic adapters > -# Depends on: CRYPTO [=y] && CRYPTO_HW [=y] && DEBUG_KERNEL [=y] && ZCRYPT [=m] > -# Location: > -# -> Cryptographic API (CRYPTO [=y]) > -# -> Hardware crypto devices (CRYPTO_HW [=y]) > -# -> Support for s390 cryptographic adapters (ZCRYPT [=m]) > -# > -# > -# > -# CONFIG_ZCRYPT_DEBUG is not set > -- > GitLab It sounds like this might be useful on debug kernels, I'd recommend disabling it in common/generic/ and enabling it in common/debug/. -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
