On Tue, 13 Oct 2020 09:51:44 -0500, Justin Forbes wrote: > The extra newline was a mistake that I saw when viewing the MR on > gitlab, so I thought I would be quick and edit it using their web UI, > but it deleted the newline at the end of the file. I added that > newline back, and the V4 patch is now correct. So clearly, you are not > nacking the patch for that reason. If you want to nack the series, > that's fine, but some context would be worthwhile there. I explained it in v3: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx/message/HRAQ3Z2A5JXZGVZ2R3MPWO5O3HGED7O7/ Then you sent v4 without addressing this. Not sure what more I can do. What I expect is you sending v5 with just two patches. Patch 3 and patch 4 should be folded into patch 1. Jiri _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
