On Tue, Oct 13, 2020 at 9:36 AM Jiri Benc <jbenc@xxxxxxxxxx> wrote: > > On Tue, 13 Oct 2020 14:19:35 -0000, GitLab Bridge on behalf of jmflinuxtx wrote: > > diff --git a/redhat/configs/common/generic/CONFIG_SPEAKUP_SYNTH_DUMMY b/redhat/configs/common/generic/CONFIG_SPEAKUP_SYNTH_DUMMY > > index fc91de6e3981..5df68ceb1363 100644 > > --- a/redhat/configs/common/generic/CONFIG_SPEAKUP_SYNTH_DUMMY > > +++ b/redhat/configs/common/generic/CONFIG_SPEAKUP_SYNTH_DUMMY > > @@ -1,2 +1 @@ > > -# CONFIG_SPEAKUP_SYNTH_DUMMY is not set > > - > > +# CONFIG_SPEAKUP_SYNTH_DUMMY is not set > > \ No newline at end of file > > Nacked-by: Jiri Benc <jbenc@xxxxxxxxxx> The extra newline was a mistake that I saw when viewing the MR on gitlab, so I thought I would be quick and edit it using their web UI, but it deleted the newline at the end of the file. I added that newline back, and the V4 patch is now correct. So clearly, you are not nacking the patch for that reason. If you want to nack the series, that's fine, but some context would be worthwhile there. Justin _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
