Re: [OS-BUILD PATCHv2 0/23] ARK: disable uncommon net/sched modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/30/20 10:19 AM, Marcelo Ricardo Leitner wrote:
> On Thu, Jul 30, 2020 at 09:50:54AM -0400, Prarit Bhargava wrote:
>> On 7/29/20 1:29 PM, Marcelo Ricardo Leitner wrote:
>>> On Wed, Jul 29, 2020 at 04:24:39PM -0000, GitLab Bridge on behalf of Justin Forbes wrote:
>>> ...
>>>>> Also,
>>>>> redhat/Makefile:
>>>>> dist-configs: dist-configs-prep
>>>>>         @cd $(REDHAT)/configs; VERSION=$(KVERSION)
>>>> ./generate_all_configs.sh rhel 1; \
>>>>>
>>>> ^^^^
>>>>>         ./process_configs.sh $(PROCESS_CONFIGS_OPTS) $(PACKAGE_NAME)
>>>> $(KVERSION)
>>>>>
>>>>> fedora-configs: DIST_TARGET=fedora
>>>>> fedora-configs: dist-configs
>>>>>
>>>>
>>>> To be honest, I am not sure that there is any value in target at all
>>>> with ARK, we build a single source rpm for both rawhide and ELN, using
>>>> both Fedora and RHEL configs.  If one fails, it all fails.
>>>
>>
>> That's odd.  I could swear I noticed some use of TARGET but maybe I was confused.
>>
>>> Well, I'm trying to check both configs, so yes, I could be using a
>>> more generic make target. But even so so far I can only generate ELN
>>> ones. How can generate rawhide's without building the .src.rpm?
>>
>> rh-configs and fedora-configs were meant to be short hand for dist-configs.  You
>> end up with both sets of configs when you execute rh-configs or fedora-configs.
> 
> Oh. That's not what the help is saying, though, nor how they appear to
> be implemented:
> 
> $ make dist-full-help
> ...
>   rh-configs       - build ELN configs
>   fedora-configs   - build Fedora configs

^^ Yeah, that's because your computer is lying to you.  I'll fix that.

> ...
> 
> redhat/Makefile:
> ...
> fedora-configs: DIST_TARGET=fedora
> fedora-configs: dist-configs
> 
> rh-configs: DIST_TARGET=rhel
> rh-configs: dist-configs
> ...
> 
>>
>> For example,
>>
>> [09:45 AM root@intel-whitley-08 redhat]# cd /home/kernel-ark/redhat/configs;
>> TARGET=fedora ./build_configs.sh kernel
>> <snip output>
>> [09:46 AM root@intel-whitley-08 configs]# ls *.config
>> kernel-aarch64-debug-fedora.config       kernel-i686-rhel.config
>> kernel-aarch64-debug-rhel.config         kernel-ppc64le-debug-fedora.config
>> kernel-aarch64-fedora.config             kernel-ppc64le-debug-rhel.config
>> kernel-aarch64-rhel.config               kernel-ppc64le-fedora.config
>> kernel-armv7hl-debug-fedora.config       kernel-ppc64le-rhel.config
>> kernel-armv7hl-debug-rhel.config         kernel-s390x-debug-fedora.config
>> kernel-armv7hl-fedora.config             kernel-s390x-debug-rhel.config
>> kernel-armv7hl-lpae-debug-fedora.config  kernel-s390x-fedora.config
>> kernel-armv7hl-lpae-debug-rhel.config    kernel-s390x-rhel.config
>> kernel-armv7hl-lpae-fedora.config        kernel-s390x-zfcpdump-fedora.config
>> kernel-armv7hl-lpae-rhel.config          kernel-s390x-zfcpdump-rhel.config
>> kernel-armv7hl-rhel.config               kernel-x86_64-debug-fedora.config
>> kernel-i686-debug-fedora.config          kernel-x86_64-debug-rhel.config
>> kernel-i686-debug-rhel.config            kernel-x86_64-fedora.config
>> kernel-i686-fedora.config                kernel-x86_64-rhel.config
>>
>> You can get just the fedora configs by doing an 'ls -l *fedora*'.
> 
> I can only have these files, if I call the script by hand as you did
> above.
> 
> If I do just 'make dist-configs', all I get is this:
> configs ((1bcf9a283da3...))]$ ls *.config
> kernel-5.8.0-aarch64.config             kernel-5.8.0-ppc64le.config
> kernel-5.8.0-aarch64-debug.config       kernel-5.8.0-ppc64le-debug.config
> kernel-5.8.0-armv7hl.config             kernel-5.8.0-s390x.config
> kernel-5.8.0-armv7hl-debug.config       kernel-5.8.0-s390x-debug.config
> kernel-5.8.0-armv7hl-lpae.config        kernel-5.8.0-s390x-zfcpdump.config
> kernel-5.8.0-armv7hl-lpae-debug.config  kernel-5.8.0-x86_64.config
> kernel-5.8.0-i686.config                kernel-5.8.0-x86_64-debug.config
> kernel-5.8.0-i686-debug.config
> 
> which are not tagged with a target (rhel/fedora), and apparently are
> using eln values.

Oh that's odd.  Are you on Fedora or RHEL?

> 
> I'm not sure now what's the expectations for these make targets so I
> can't figure out what needs to be fixed, but a make target that
> generates tagged config files as in your listing would be very
> welcomed. :-)

Let's figure this out.

P.

> 
>   Marcelo
> 
> 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux