Re: [OS-BUILD PATCHv2 0/23] ARK: disable uncommon net/sched modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Justin Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/530#note_387675928

>
> Jeremy Cline commented:
>
> Marcelo Ricardo Leitner marcelo.leitner@xxxxxxxxx commented via email:
>
> > > --- /dev/null
> > > +++ b/redhat/configs/ark/generic/CONFIG_NET_SCH_ATM
> > > @@ -0,0 +1 @@
> > > +# CONFIG_NET_SCH_ATM is not set
> >
> > Without this patch:
> > configs ((7deb2615faaa...))]$ find -name CONFIG_NET_SCH_ATM | xargs
grep -H .
> > ./common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> >
> > Then:
> > redhat ((7deb2615faaa...))]$ make fedora-configs
> > ...
> > redhat ((7deb2615faaa...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> > configs/kernel-5.8.0-ppc64le.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-s390x-debug.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-s390x.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-x86_64-debug.config:CONFIG_NET_SCH_ATM=m
> > configs/common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-aarch64.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-aarch64-debug.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-ppc64le-debug.config:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-x86_64.config:CONFIG_NET_SCH_ATM=m
> >
> > After applying this patch:
> > configs ((7deb2615faaa...))]$ find -name CONFIG_NET_SCH_ATM | xargs
grep -H .
> > ./ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> > ./common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> >
> > redhat ((1bcf9a283da3...))]$ make fedora-configs
> > ...
> > redhat ((1bcf9a283da3...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> > configs/kernel-5.8.0-ppc64le.config:# CONFIG_NET_SCH_ATM is not set
> > configs/ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not
set
> > configs/kernel-5.8.0-s390x-debug.config:# CONFIG_NET_SCH_ATM is not
set
> > configs/kernel-5.8.0-s390x.config:# CONFIG_NET_SCH_ATM is not set
> > configs/kernel-5.8.0-x86_64-debug.config:# CONFIG_NET_SCH_ATM is not
set
> > configs/common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-aarch64.config:# CONFIG_NET_SCH_ATM is not set
> > configs/kernel-5.8.0-aarch64-debug.config:# CONFIG_NET_SCH_ATM is
not set
> > configs/kernel-5.8.0-ppc64le-debug.config:# CONFIG_NET_SCH_ATM is
not set
> > configs/kernel-5.8.0-x86_64.config:# CONFIG_NET_SCH_ATM is not set
> >
> > Then tried, just in case:
> > configs ((1bcf9a283da3...))]$ mv common/generic/CONFIG_NET_SCH_ATM
fedora/generic/
> > configs ((1bcf9a283da3...))]$ find -name CONFIG_NET_SCH_ATM | xargs
grep -H .
> > ./ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> > ./fedora/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> >
> > redhat ((1bcf9a283da3...))]$ make fedora-configs
> > ...
> > redhat ((1bcf9a283da3...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> > configs/kernel-5.8.0-ppc64le.config:# CONFIG_NET_SCH_ATM is not set
> > configs/ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not
set
> > configs/fedora/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> > configs/kernel-5.8.0-s390x-debug.config:# CONFIG_NET_SCH_ATM is not
set
> > configs/kernel-5.8.0-s390x.config:# CONFIG_NET_SCH_ATM is not set
> > configs/kernel-5.8.0-x86_64-debug.config:# CONFIG_NET_SCH_ATM is not
set
> > configs/kernel-5.8.0-aarch64.config:# CONFIG_NET_SCH_ATM is not set
> > configs/kernel-5.8.0-aarch64-debug.config:# CONFIG_NET_SCH_ATM is
not set
> > configs/kernel-5.8.0-ppc64le-debug.config:# CONFIG_NET_SCH_ATM is
not set
> > configs/kernel-5.8.0-x86_64.config:# CONFIG_NET_SCH_ATM is not set
> >
> > What am I missing, why is it mangling Fedora options as well?
>
> Don, Justin, can you have a look at this please? I may be missing some
> basic here.
>
> make fedora-configs trigger
>     cd /home/mrll/linux-ng/arkgl/redhat/configs; TARGET=fedora
./build_configs.sh kernel
> but apparently build_configs.sh ignores that TARGET variable:
>
> build_configs.sh:
> while read line
> do
>         build_flavor $line
> done < flavors
>
> $ cat flavors
> rhel
> fedora
>
> But I asked only for Fedora configs..
>
> Also,
> redhat/Makefile:
> dist-configs: dist-configs-prep
>         @cd $(REDHAT)/configs; VERSION=$(KVERSION)
./generate_all_configs.sh rhel 1; \
>
^^^^
>         ./process_configs.sh $(PROCESS_CONFIGS_OPTS) $(PACKAGE_NAME)
$(KVERSION)
>
> fedora-configs: DIST_TARGET=fedora
> fedora-configs: dist-configs
>

To be honest, I am not sure that there is any value in target at all
with ARK, we build a single source rpm for both rawhide and ELN, using
both Fedora and RHEL configs.  If one fails, it all fails.

Justin
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux