Re: [OS-BUILD PATCHv2 10/23] redhat: ark: disable CONFIG_NET_SCH_ATM

[Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>]

On Tue, Jul 28, 2020 at 06:28:55PM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Jul 28, 2020 at 01:03:09PM -0000, GitLab Bridge on behalf of dcaratti wrote:
> > --- /dev/null
> > +++ b/redhat/configs/ark/generic/CONFIG_NET_SCH_ATM
> > @@ -0,0 +1 @@
> > +# CONFIG_NET_SCH_ATM is not set
> 
> Without this patch:
> configs ((7deb2615faaa...))]$ find -name CONFIG_NET_SCH_ATM | xargs grep -H .
> ./common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> 
> Then:
> redhat ((7deb2615faaa...))]$ make fedora-configs
> ...
> redhat ((7deb2615faaa...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> configs/kernel-5.8.0-ppc64le.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-s390x-debug.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-s390x.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-x86_64-debug.config:CONFIG_NET_SCH_ATM=m
> configs/common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-aarch64.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-aarch64-debug.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-ppc64le-debug.config:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-x86_64.config:CONFIG_NET_SCH_ATM=m
> 
> After applying this patch:
> configs ((7deb2615faaa...))]$ find -name CONFIG_NET_SCH_ATM | xargs grep -H .
> ./ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> ./common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> 
> redhat ((1bcf9a283da3...))]$ make fedora-configs
> ...
> redhat ((1bcf9a283da3...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> configs/kernel-5.8.0-ppc64le.config:# CONFIG_NET_SCH_ATM is not set
> configs/ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-s390x-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-s390x.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-x86_64-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/common/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-aarch64.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-aarch64-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-ppc64le-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-x86_64.config:# CONFIG_NET_SCH_ATM is not set
> 
> Then tried, just in case:
> configs ((1bcf9a283da3...))]$ mv common/generic/CONFIG_NET_SCH_ATM fedora/generic/
> configs ((1bcf9a283da3...))]$ find -name CONFIG_NET_SCH_ATM | xargs grep -H .
> ./ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> ./fedora/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> 
> redhat ((1bcf9a283da3...))]$ make fedora-configs
> ...
> redhat ((1bcf9a283da3...))]$ grep -r CONFIG_NET_SCH_ATM configs/
> configs/kernel-5.8.0-ppc64le.config:# CONFIG_NET_SCH_ATM is not set
> configs/ark/generic/CONFIG_NET_SCH_ATM:# CONFIG_NET_SCH_ATM is not set
> configs/fedora/generic/CONFIG_NET_SCH_ATM:CONFIG_NET_SCH_ATM=m
> configs/kernel-5.8.0-s390x-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-s390x.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-x86_64-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-aarch64.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-aarch64-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-ppc64le-debug.config:# CONFIG_NET_SCH_ATM is not set
> configs/kernel-5.8.0-x86_64.config:# CONFIG_NET_SCH_ATM is not set
> 
> What am I missing, why is it mangling Fedora options as well?

Don, Justin, can you have a look at this please? I may be missing some
basic here.

make fedora-configs trigger
    cd /home/mrll/linux-ng/arkgl/redhat/configs; TARGET=fedora ./build_configs.sh kernel
but apparently build_configs.sh ignores that TARGET variable:

build_configs.sh:
while read line
do
        build_flavor $line
done < flavors

$ cat flavors
rhel
fedora

But I asked only for Fedora configs..

Also,
redhat/Makefile:
dist-configs: dist-configs-prep
        @cd $(REDHAT)/configs; VERSION=$(KVERSION) ./generate_all_configs.sh rhel 1; \
                                                                             ^^^^
        ./process_configs.sh $(PROCESS_CONFIGS_OPTS) $(PACKAGE_NAME) $(KVERSION)

fedora-configs: DIST_TARGET=fedora
fedora-configs: dist-configs

Thanks,
Marcelo
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx