Re: kernel-ark | Pipeline #145379201 has failed for osnamechange | 1b1d4554 in !354

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 13, 2020 at 10:13 AM Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
>
> On 5/13/20 10:31 AM, Don Zickus wrote:
> > On Wed, May 13, 2020 at 07:22:45AM -0400, Prarit Bhargava wrote:
> >> On 5/13/20 3:50 AM, Jiri Benc wrote:
> >>> On Tue, 12 May 2020 20:19:09 -0400, Prarit Bhargava wrote:
> >>>> My patch in merge request 354 changes the names of makefile targets from rh-* to
> >>>> dist-*
> >>>
> >>> I haven't seen that patch on kernel@xxxxxxxxxxxxxxxxxxxxxxx. What's
> >>> going on?
> >
> > The piece of the puzzle you are probably missing is:
> > https://gitlab.com/cki-project/kernel-ark-ci
> >
>
> Thanks.  That's what I was looking for.
>
> > which holds the CI scripts.  It is in a separate repo for security reasons
> > (don't want a kernel change to include modifying the CI scripts to falsely
> > pass something malicious).
> >
> > However, that split leads to the scenario you are in, how to update both at
> > the same time, which we were trying to avoid again for security reasons
> > (always want to use either a tag or head of master, not a custom branch for
> > the CI scripts).
> >
> > We may have to create a transition patch to handle this.  Unfortunately you
> > hit this scenario sooner than we were expecting to deal with it. :-(
>
> Heh :)  Of course it's my fault :) :)
>
> How about these steps?
>
> 1) I patch to add the dist-* targets and keep the old rh-* targets temporarily.
> This patch will be messy unless someone has some  Makefile-fu.
> 2) I modify the kernel-ark-ci scripts to use the dist-* targets.
> 3) I patch to remove the old rh-* targets which will result in an overall clean
> patch.
>
> Would that work for everyone?
>
This seems unnecessarily messy. Why not modify the CI scripts to check
both and as long as at least one of them passes, CI passes?

Justin
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux