On Wed, 2020-04-15 at 11:15 +0200, Thorsten Leemhuis wrote: > Am 15.04.20 um 04:24 schrieb Paul Moore: > > On Tue, Apr 14, 2020 at 9:52 PM Paul Moore <paul@xxxxxxxxxxxxxx> > > wrote: > > > > There is another change in the kernel's specfile relating to where > > the > > %buildid is inserted into the version string. Previously the > > kernel > > NVR would look like this: > > > > kernel-5.6.0-0.rc7.git1.1.BUILDID.fc33.src.rpm > > > > ... but now it looks like this: > > > > kernel-5.7.0-0.rc1.20200414git8632e9b5645b.1.fc33.BUILDID.src.rpm > > > > Any chance you can change the specfile so that the %buildid comes > > before %dist as it did in the past? Should be straight-forward, I'll take care of that today. > > And how about making it a bit shorter? Until now I added > ".vanilla.knurd.1" for my vanilla builds > (https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories ), but > doing > that now exceeds the 64 char limit now and thus results in build > error. > No big deal, I can remove the ".knurd", but I liked the old way more, > as > that made it more obvious *what* kind of kernel this is and *who* > built it. > > And is the "2020" really that important when we have 5.7-rc1 already? > How about changing "20200414git" to "0414g" and get something like > this > (saves 7 chars): > > kernel-5.7.0-0.rc1.0414g8632e9b5645b.1.fc33.BUILDID.src.rpm > > Anyway, I don't care to much, just a suggestion, no need for a big > bike > shedding debate. > So the current format follows the snapshot guidelines[0], but it *is* very long. While it's nice to follow the guidelines, the package hasn't been compliant before this so I suppose it's not terrible to bend the rules. I'm okay with this adjustment if folks are okay with treating the guidelines like... guidelines. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots - Jeremy _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
