On 11/06/2018 11:03 AM, Justin Forbes wrote: > On Tue, Nov 6, 2018 at 7:09 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: >> Paul Bolle schreef op di 06-11-2018 om 13:54 [+0100]: >>> There are 204 Kconfig symbols referenced in the files used for >>> configuration generation and in the shipped .config files that are >>> unknown in v4.20-rc1. Neither are these symbols added in the patches >>> that Fedora applies. The references to these symbols can be safely >>> removed. >>> >>> These symbols are: >>> CONFIG_8723AU_AP_MODE >>> [...] >>> CONFIG_W1_SLAVE_DS2760 >>> >>> Reported-by: Paul Bolle <pebolle@xxxxxxxxxx> >> >> This patch is, clearly, impossible to review. >> >> My hope is that someone with access to Fedora's build system tests this patch. >> Because, if the patch is good the final .config files - the .config files used >> to actually build the various kernels that Fedora ships - should not change. >> (Note that the kernel's build system will simply drop unknown symbols, so they >> should have no effect whatsoever.) Of course, I'll be glad to assist here. >> >> Is my idea feasible? >> >> Regards, >> >> >> Paul Bolle > > I will go through and test these. Realistically it takes both a > nondebug build and a debug build across all architectures. koji > scratch works there. Or I suppose a script to grep through the > Kconfig files and search for each config option. > I found 227 using, find_dead_configs.sh: #!/bin/bash # git clone https://src.fedoraproject.org/git/rpms/kernel.git # copied this script into top dir, ie kernel # make prep # -- provides kernel/kernel-4.19.fc30/linux-4.20.0-0.rc1.git0.1.fc30.x86_64/configs # then run ./find_dead_configs.sh awk ' /is not set/ { split ($0, a, "#"); split(a[2], b); print b[1] ; } /=/ { split ($0, a, "="); print a[1]; } ' kernel-4.19.fc30/linux-4.20.0-0.rc1.git0.1.fc30.x86_64/configs/*.config | sort -u > .finalconfiglist find ./configs/fedora -name CONFIG_* | sed 's!.*/!!' | sort -u > .configlist echo "These CONFIGS defined in redhat/configs but are not in the final .configs:" diff -u .finalconfiglist .configlist | grep "^+CONFIG" | sed 's/^+//g' | while read FILENAME do # configs sometimes are set to =n which is wrong. FILENAME=$(echo $FILENAME | awk -F "=" ' { print $1 } ') egrep -w $FILENAME kernel-4.19.fc30/linux-4.20.0-0.rc1.git0.1.fc30.x86_64/ --recursive >& /dev/null if [ $? -ne 0 ]; then echo $FILENAME # uncomment next line to remove files #find ./configs/fedora -name $FILENAME | xargs rm -f fi done rm -f .configlist .finalconfiglist The output of the script is: [prarit@prarit kernel]$ ./find_dead_configs.sh These CONFIGS defined in redhat/configs but are not in the final .configs: CONFIG_8723AU_AP_MODE CONFIG_8723AU_BT_COEXIST CONFIG_ACPI_NFIT_DEBUG CONFIG_ACPI_PROCFS CONFIG_ADE7753 CONFIG_ADE7754 CONFIG_ADE7758 CONFIG_ADE7759 CONFIG_ADIS16060 CONFIG_ALTERNATIVES CONFIG_ARM64_PTDUMP CONFIG_ARM_ASM_UNIFIED CONFIG_ARM_DT_BL_CPUFREQ CONFIG_ARM_PTDUMP CONFIG_ATH9K_DEBUG CONFIG_AXON_RAM CONFIG_BACKLIGHT_LM3630 CONFIG_BLK_DEV_NVME_SCSI CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK CONFIG_BUILD_DOCSRC CONFIG_BUILD_ID_SALT CONFIG_CC_STACKPROTECTOR_AUTO CONFIG_CC_STACKPROTECTOR_NONE CONFIG_CIFS_SMB2 CONFIG_CIFS_SMB311 CONFIG_CMDLINE_FROM_BOOTLOADER CONFIG_CONFIG_PINCTRL_LEWISBURG CONFIG_CONSISTENT_SIZE_BOOL CONFIG_CPU_FREQ_STAT_DETAILS CONFIG_CPU_NOTIFIER_ERROR_INJECT CONFIG_CRYPTO_CRC32_ARM64 CONFIG_CRYPTO_CRC32_ARM64_CE CONFIG_CRYPTO_DEV_NX_COMPRESS CONFIG_CRYPTO_MCRYPTD CONFIG_CRYPTO_SALSA20_586 CONFIG_CRYPTO_SALSA20_X86_64 CONFIG_CRYPTO_SHA1_MB CONFIG_CRYPTO_SHA256_MB CONFIG_CRYPTO_SHA512_MB CONFIG_CRYPTO_SKEIN CONFIG_CTC CONFIG_DEBUG_KMEMLEAK_EARLY CONFIG_DEBUG_NX_TEST CONFIG_DEBUG_REFCOUNT CONFIG_DEBUG_SET_MODULE_RONX CONFIG_DEFAULT_BOOTPARAM_HUNG_TASK_PANIC CONFIG_DGAP CONFIG_DGNC CONFIG_DIRECT_GBPAGES CONFIG_DISABLE_MPROFILE_KERNEL CONFIG_DISCONTIGMEM_MANUAL CONFIG_DM_CACHE_CLEANER CONFIG_DM_MQ_DEFAULT CONFIG_DRM_AMD_DC_FBC CONFIG_DRM_AMD_DC_PRE_VEGA CONFIG_DRM_AMD_POWERPLAY CONFIG_DRM_DEBUG_MM_SELFTEST CONFIG_DRM_ETNAVIV_REGISTER_LOGGING CONFIG_DRM_OMAP_NUM_CRTCS CONFIG_DRM_TILCDC_SLAVE_COMPAT CONFIG_DT3155 CONFIG_DVB_USB_FRIIO CONFIG_DW_DMAC_BIG_ENDIAN_IO CONFIG_EADC_AMD64 CONFIG_EFI_ALLOW_SECURE_BOOT_EXIT CONFIG_EFI_SECURE_BOOT_LOCK_DOWN CONFIG_EFI_SECURE_BOOT_SIG_ENFORCE CONFIG_FB_AUO_K190X CONFIG_FUJITSU_LAPTOP_DEBUG CONFIG_GPIO_AXP209 CONFIG_GPIO_DEVRES CONFIG_GPIO_MCP23S08 CONFIG_GPIO_SX150X CONFIG_HFI1_VERBS_31BIT_PSN CONFIG_HFSPLUS_FS_POSIX_ACL CONFIG_HT_IRQ CONFIG_I2C_DESIGNWARE CONFIG_I2O CONFIG_I40E_FCOE CONFIG_I7300_IDLE CONFIG_IDMA64 CONFIG_IMA_TRUSTED_KEYRING CONFIG_INFINIBAND_CXGB3_DEBUG CONFIG_INFINIBAND_EXP_USER_ACCESS CONFIG_INPUT_GPIO_TILT_POLLED CONFIG_INTEL_RDT_A CONFIG_IOMMU_STRESS CONFIG_IP_DCCP_CCID2 CONFIG_IPL CONFIG_IPV6_SEG6_INLINE CONFIG_IR_LIRC_CODEC CONFIG_IRQ_DOMAIN_DEBUG CONFIG_IWM CONFIG_KEXEC_SIG CONFIG_KEXEC_SIG_FORCE CONFIG_KGDB_GDB CONFIG_KVM_DEVICE_ASSIGNMENT CONFIG_LCD_LD9040 CONFIG_LCD_S6E63M0 CONFIG_LGUEST CONFIG_LGUEST_GUEST CONFIG_LIRC_BT829 CONFIG_LIRC_IMON CONFIG_LIRC_PARALLEL CONFIG_LIRC_SERIAL CONFIG_LIRC_SERIAL_TRANSMITTER CONFIG_LIRC_STAGING CONFIG_LIRC_ZILOG CONFIG_LNET CONFIG_LPFC_NVME_INITIATOR CONFIG_LPFC_NVME_TARGET CONFIG_MACH_MESON8B CONFIG_MCE_AMD_INJ CONFIG_MEDIA_CEC_DEBUG CONFIG_MEDIA_RC_SUPPORT CONFIG_MFD_CROS_EC_I2C CONFIG_MG_DISK CONFIG_MLX_CPLD_PLATFORM CONFIG_MOVABLE_NODE CONFIG_MTD_NAND_DOCG4 CONFIG_MTD_NAND_PXA3xx CONFIG_MVEBU_CLK_CORE CONFIG_NET_CLS_ROUTE CONFIG_NET_DSA_HWMON CONFIG_NETFILTER_DEBUG CONFIG_NET_SCTPPROBE CONFIG_NET_VENDOR_SNI CONFIG_NFC_WILINK CONFIG_NFP_NET_DEBUG CONFIG_NFP_NETVF CONFIG_NFT_BRIDGE_META CONFIG_NFT_RBTREE CONFIG_NFT_RT CONFIG_NFT_SET_BITMAP CONFIG_NFT_SET_HASH CONFIG_NFT_SET_RBTREE CONFIG_NL80211 CONFIG_NMI_LOG_BUF_SHIFT CONFIG_NO_BOOTMEM CONFIG_NO_HZ_FULL_ALL CONFIG_NR_DEV_DAX CONFIG_OLPC_XO1 CONFIG_OMAP2_DSS_RFBI CONFIG_OMAP_PACKAGE_CBB CONFIG_OMAP_PACKAGE_CUS CONFIG_OMAP_PM_NOOP CONFIG_PC104 CONFIG_PHY_MIPHY365X CONFIG_PHY_STIH41X_USB CONFIG_PNFS_OBJLAYOUT CONFIG_POWER5_CPU CONFIG_POWER6_CPU CONFIG_PPC_CPUFEATURES_ENABLE_UNKNOWN CONFIG_PPC_ICSWX CONFIG_PPC_ICSWX_PID CONFIG_PPC_ICSWX_USE_SIGILL CONFIG_PPC_PMAC64 CONFIG_PROVE_RCU_REPEATEDLY CONFIG_QETH_IPV6 CONFIG_R8723AU CONFIG_RCU_KTHREAD_PRIO CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP CONFIG_RCU_TORTURE_TEST_SLOW_INIT CONFIG_RCU_TORTURE_TEST_SLOW_INIT_DELAY CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT CONFIG_RESET_GPIO CONFIG_RESET_HSDK_V1 CONFIG_RIO CONFIG_RTC_DRV_ISL12057 CONFIG_RTC_DS1685_PROC_REGS CONFIG_RTC_DS1685_SYSFS_REGS CONFIG_S390_GUEST_OLD_TRANSPORT CONFIG_SAMSUNG_USBPHY CONFIG_SCM_BLOCK_CLUSTER_WRITE CONFIG_SCSI_EATA CONFIG_SCSI_EATA_PIO CONFIG_SCSI_FUTURE_DOMAIN CONFIG_SCSI_IN2000 CONFIG_SCSI_SRP CONFIG_SECURITY_SELINUX_POLICYDB_VERSION_MAX CONFIG_SENSORS_TWL4030_MADC CONFIG_SHARED_KERNEL CONFIG_SIGMA CONFIG_SILEAD_DMI CONFIG_SND_DAVINCI_SOC CONFIG_SND_SOC_DIO2125 CONFIG_SOC_EXYNOS4212 CONFIG_SOC_EXYNOS4415 CONFIG_SOC_EXYNOS5440 CONFIG_SOC_ZTE CONFIG_SOLO6X10 CONFIG_SPARSE_RCU_POINTER CONFIG_SSB_SILENT CONFIG_STE_MODEM_RPROC CONFIG_STRIP CONFIG_SYNOPSYS_DWC_ETH_QOS CONFIG_TEST_FIND_BIT CONFIG_TI_DAC7512 CONFIG_TOUCHSCREEN_FT6236 CONFIG_TOUCHSCREEN_INTEL_MID CONFIG_TR CONFIG_TRACE_ENUM_MAP_FILE CONFIG_TSL2x7x CONFIG_UCSI CONFIG_USB_ATMEL CONFIG_USB_GADGET_LEGACY CONFIG_USB_OHCI_HCD_SSB CONFIG_USB_SERIAL_KEYSPAN_MPR CONFIG_USB_SERIAL_KEYSPAN_USA18X CONFIG_USB_SERIAL_KEYSPAN_USA19 CONFIG_USB_SERIAL_KEYSPAN_USA19QI CONFIG_USB_SERIAL_KEYSPAN_USA19QW CONFIG_USB_SERIAL_KEYSPAN_USA19W CONFIG_USB_SERIAL_KEYSPAN_USA28 CONFIG_USB_SERIAL_KEYSPAN_USA28X CONFIG_USB_SERIAL_KEYSPAN_USA28XA CONFIG_USB_SERIAL_KEYSPAN_USA28XB CONFIG_USB_SERIAL_KEYSPAN_USA49W CONFIG_USB_SERIAL_KEYSPAN_USA49WLC CONFIG_USE_THIN_ARCHIVES CONFIG_VIDEO_CPIA CONFIG_VIDEO_SAMSUNG_S5P_TV CONFIG_VIDEO_SH_MOBILE_CSI2 CONFIG_VIDEO_STK1160_AC97 CONFIG_VIDEO_TW686X_KH CONFIG_W1_SLAVE_BQ27000 CONFIG_XEN_DEBUG P. > Justin > _______________________________________________ > kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx > _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
