On 06/13/2016 09:16 PM, Josh Boyer wrote:
> On Mon, Jun 13, 2016 at 4:34 PM, Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
>> Agreed (although I reserve the right to complain about minuscule things in
>> future and have jboyer ignore those too :) :) ).
>
> I only ignore them if they're misplaced. If we were suggesting this
> script was "THE" way to do builds then you'd have totally valid
> arguments. But that's not the case. It's a helper, for arguably
> community outreach purposes.
FWIW ... a real comment on the patch:
I've used --target in two cases. The first is to do specific noarch builds that
bundle non-arch specific stuff like a bunch of scripts, and the second is to
cross build.
For example (taken from a script of mine) to check builds across different arches:
CROSS_RPMFLAGS = $(RPMBUILD) --define "_sourcedir $(SOURCES)" --define
"_builddir $(RPM)/BUILD" --define "_srcrpmdir $(RPM)/SRPMS" --define "_rpmdir
$(RPM)/RPMS" --define "_specdir $(RPM)/SPECS" --define "dist $(DIST)"
$(CROSS_RPMFLAGS) --target ppc64 --with cross --without debuginfo -bc
$(RPM)/SOURCES/kernel.spec
$(CROSS_RPMFLAGS) --target s390x --with cross --without debuginfo -bc
$(RPM)/SOURCES/kernel.spec
$(CROSS_RPMFLAGS) -ba $(RPM)/SOURCES/kernel.spec
--target implies to me that we can cross build. I think the script should
probably be updated with a note that the script is not meant to be used for
cross building. The other option is to add with "--with cross", although I'm
not sure what the ramification of "--with cross" is when building natively.
>
> At any rate, it's a friendly ignore if you can conceive of it that way.
>
I absolutely took it that way! :)
P.
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/kernel@xxxxxxxxxxxxxxxxxxxxxxx
