Hi,
On 29-07-15 17:06, Josh Boyer wrote:
On Tue, Jul 29, 2014 at 8:35 AM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote:
On Mon, Jul 28, 2014 at 2:12 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi Josh,
On 07/28/2014 07:04 PM, Josh Boyer wrote:
commit e6fe382d1d53d4cdf9b544729dc823d4eab0217c
Author: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
Date: Mon Jul 28 13:03:01 2014 -0400
Make sure acpi brightness_switch is disabled (like forever in Fedora)
Upstream reverted the change to turn the ACPI brightness_switch_enabled
parameter off by default. Revert the revert so we go back to the state
Fedora has traditionally been in.
Ack, I was planning on doing this myself but you beat me to it, thanks for
taking care of this.
Note that 3.17 will have this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=8ab58e8e7e097bae5fe39cbc67eb93a91f7134b7
Which fixes the 2 steps being taken for one keypress problem while
keeping the acpi brightness_switch behavior enabled, so that people who
have an acpi-video controlled backlight and a userspace which does not
do backlight control (e.g. windowmaker).
So for 3.17 we should IMHO drop the revert-revert and stick with
upstream behavior.
OK.
Oops. The revert-revert patch was never actually dropped so long ago.
So we're still defaulting the ACPI brightness_switch_enabled parameter
off by default in Fedora.
If you still believe we should drop it
Yes I still believe we should drop it, the kernel has had a workaround
for the double brightness changes this used to cause for quite some
while now, and the closer to upstream we are the better IMHO.
Regards,
Hans
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel
