On Fri, Jan 07, 2011 at 06:26:07PM -0800, JD wrote: > On 01/07/2011 05:58 PM, Mr Dash Four wrote: > > > >>I just implemented exactly what I described here locally, and it worked > >>perfectly. The config-local file needs to be a Source: file so that it > >>actually gets included in the source rpm, and I'm not sure why you're > >>doing anything touching debuginfo bits... > >> > >>My test case was to simply add CONFIG_VIDEO_VIA_CAMERA=y to my > >>config-local, as I know its disabled in the stock config, because it > >>doesn't build (due to a dependency on updated viafb bits in 2.6.37). I > >>created a source rpm with that modified config-local, then did an > >>rpmbuild, and it failed on drivers/media/video/via-camera.c exactly like > >>I'd expected it to. So I suspect you've either done something wrong with > >>your implementation or you execution. :) > >Yet another kernel build error: > > > >drivers/media/video/em28xx/em28xx-vbi.c:49: error: implicit > >declaration of function 'in_interrupt' > >make[4]: *** [drivers/media/video/em28xx/em28xx-vbi.o] Error 1 > >make[3]: *** [drivers/media/video/em28xx] Error 2 > >make[3]: *** Waiting for unfinished jobs.... > >make[2]: *** [drivers/media/video] Error 2 > >make[1]: *** [drivers/media] Error 2 > >make[1]: *** Waiting for unfinished jobs.... > >make: *** [drivers] Error 2 > >make: *** Waiting for unfinished jobs.... > >+ exit 1 > >error: Bad exit status from /var/tmp/rpm-tmp.Di6kj9 (%build) > > > > > The function in_interrupt is a macro defined in > linux-2.6.35.<YOUR_ARCH>/include/linux/hardirq.h > which gets included by > linux-2.6.35.<YOUR_ARCH>/include/linux/interrupt.h > but the file > drivers/media/video/em28xx/em28xx-vbi.c > dos not include this header. > So, this is obviously a bug of omission. Already fixed in the latest upstream source by way of including hardirq.h. -- Jarod Wilson jarod@xxxxxxxxxx _______________________________________________ kernel mailing list kernel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/kernel
