On Sat, 2020-05-16 at 13:41 -0700, Kevin Fenzi wrote:
> On Sat, May 16, 2020 at 02:04:57PM +0200, Nils Philippsen wrote:
> > On Thu, 2020-05-14 at 11:37 -0700, Kevin Fenzi wrote:
> > > Awesome work!
> > >
> > > So nice to have CI (of any kind) running. :)
> > >
> > > So what does ansible-review check for currently? whats a failure?
> >
> > I've looked into it and there isn't an easy answer, except that the
> > way
> > it's set up right now, we don't gate on it, its output is advisory.
> >
> > As I understand the code(*), by default ansible-review considers
> > most
> > things it flags a mere warning, except if a variable is used bare
> > instead of being flanked by "{{ ... }}". We could make our own
> > standards and additional lint rules, if we needed, though.
>
> I think we may want to at some point.
>
> Does it at least catch syntax errors right now?
>
> ie, mismatched "s or bad indents, etc?
Sorry it took me so long to reply. I just assumed it did, and looking
into it had to find out that it doesn't.
Additionally to running ansible-review, we could let Zuul run "ansible-
playbook --check ..." on affected YAML files, which would fail on
problems like this.
Nils
--
Nils Philippsen "Those who would give up Essential Liberty to
Software Engineer purchase a little Temporary Safety, deserve neither
Red Hat Liberty nor Safety." -- Benjamin Franklin, 1759
PGP fingerprint: D0C1 1576 CDA6 5B6E BBAE 95B2 7D53 7FCA E9F6 395D
old: C4A8 9474 5C4C ADE3 2B8F 656D 47D8 9B65 6951 3011
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
