On Sat, May 16, 2020 at 02:04:57PM +0200, Nils Philippsen wrote: > On Thu, 2020-05-14 at 11:37 -0700, Kevin Fenzi wrote: > > Awesome work! > > > > So nice to have CI (of any kind) running. :) > > > > So what does ansible-review check for currently? whats a failure? > > I've looked into it and there isn't an easy answer, except that the way > it's set up right now, we don't gate on it, its output is advisory. > > As I understand the code(*), by default ansible-review considers most > things it flags a mere warning, except if a variable is used bare > instead of being flanked by "{{ ... }}". We could make our own > standards and additional lint rules, if we needed, though. I think we may want to at some point. Does it at least catch syntax errors right now? ie, mismatched "s or bad indents, etc? kevin
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx