Re: A short reminder on commit messages, freezes and hotfixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 06, 2019 at 10:36:16PM -0500, Todd Zullinger wrote:
> Hi,
> 
> Kevin Fenzi wrote:
> > 2. We are in freeze, so please get freeze breaks for any frozen hosts.
> > Of course if something is down/on fire you can push the fix and then go
> > back and make sure it gets approved. This will get a bunch easier when
> > we have ansible repo in pagure.
> 
> Until the ansible repo is in pagure, a git alias could
> probably make generating the patches for freeze break
> requests a little easier.  Something like this:
> 
>     git config alias.fbr \
>         "format-patch --subject-prefix='Freeze Break Request' --to=infrastructure@xxxxxxxxxxxxxxxxxxxxxxx"
> 
> And then you can generate a patch (or patches) via:
> 
>     git fbr @{U}
> 
> or
> 
>     git fbr -1
>     
> or any other options to the git format-patch command.
> 
> The resulting file(s) can then be sent via git send-email
> (or with any mail client that can read in files in mbox
> without munging them up).
> 
> Additional comments can be added to the patch file between
> the "---" and the diffstat, which is ignored when applying
> using git am.
> 
> If using git send-email, the default to address can be put
> in the sendemail config rather than embedded in the fbr
> alias, e.g.:
> 
>     git config sendemail.to infrastructure@xxxxxxxxxxxxxxxxxxxxxxx

So I've been looking to use this as it sounds most helpful, thanks for sharing
this! :)

If I understand it correctly, it comes down to adding these lines to the
.git/config of the ansible repo:
'''
[alias]
    fbr = format-patch --subject-prefix='FBR' --to=infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
[sendemail]
	to = infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
'''

I have one question though, what is the --to used for in the format-patch if git
send-email doesn't support reading from it? (which is the case from what I saw
yesterday)

Thanks again,
Pierre

Attachment: signature.asc
Description: PGP signature

_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux