Mohan I am +1 but would also like variabels. On Wed, 6 Mar 2019 at 15:25, Kevin Fenzi <kevin@xxxxxxxxx> wrote: > > On 3/6/19 12:16 PM, Mohan Boddu wrote: > > Please review the FBR and +1 it, thanks. > > > > diff --git a/roles/bodhi2/backend/templates/pungi.rpm.conf.j2 > > b/roles/bodhi2/backend/templates/pungi.rpm. > > index b0742ec..8d9e9a3 100644 > > --- a/roles/bodhi2/backend/templates/pungi.rpm.conf.j2 > > +++ b/roles/bodhi2/backend/templates/pungi.rpm.conf.j2 > > @@ -27,6 +27,8 @@ sigkeys = [ > > '9db62fb1', > > [% elif release.version_int == 29 %] > > '429476b4', > > +[% elif release.version_int == 30 %] > > + 'cfc659b9', > > [% elif release.version_int == 6 %] > > '0608b895', > > [% elif release.version_int == 7 %] > > +1 > > We should probibly change this to use the variables, and add one for the > keys so we don't retype them all over the place. > > kevin > > > > _______________________________________________ > infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx -- Stephen J Smoogen. _______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
