This was applied and closed. On Thu, 30 Aug 2018 at 19:17, Stephen John Smoogen <smooge@xxxxxxxxx> wrote: > > On Thu, 30 Aug 2018 at 17:27, Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> wrote: > > > > This change is for staging only, so I'm not convinced a FBR is needed. > > But here is my review anyway. > > > > 1. you added host vars for > > osbs-aarch64-node01.stg.arm.fedoraproject.org, but this host is not in > > inventory > > > > I had already staged this by the time we decided we might and I > emphasize might not need it. I wanted to keep it in case we do and > then we need to work on it. If it doesn't need to be used a git rm > will remove it later. > > > 2. kickstart file kvm-fedora-aarch64-28-osbs does not exist > > > > Thanks.. I mixed up things. > > > > 3. You set osbs_odcs_enabled to true, but ODCS does not support aarch64 > > AFAIR (it works on x86_64 only I think) > > > > Most likely. I am probably the least knowledgeble person to have done > this but hey here we are.. > > > > 4. playbooks/groups/osbs-cluster.yml should probably be updated to to > > provision newly added hosts > > > > It looks that some changes are needed for this to work. > > > > cverna is working on that part and put it in > playbooks/groups/osbs/aarch64/cluster_deployment.yml > > > > > > On 08/30/2018 10:50 PM, Stephen John Smoogen wrote: > > > Third time is supposedly the charm they say > > > On Thu, 30 Aug 2018 at 16:42, Dennis Gilmore <dennis@xxxxxxxx> wrote: > > >> > > >> +1 also thanks > > >> El jue, 30-08-2018 a las 16:23 -0400, Stephen John Smoogen escribió: > > >>> Talked with cverna on IRC and made changes from that. Please review > > >>> this one. > > >>> On Thu, 30 Aug 2018 at 14:48, Stephen John Smoogen <smooge@xxxxxxxxx> > > >>> wrote: > > >>>> > > >>>> This needs review by both infrastructure and people who are > > >>>> familiar > > >>>> with osbs. I am mostly copya pasta editing here so it may or may > > >>>> not > > >>>> work. It is also not clear if we need both a master and a node or > > >>>> just > > >>>> a master. > > >>>> > > >>>> > > >>>> -- > > >>>> Stephen J Smoogen. > > >>> > > >>> > > >>> > > >>> _______________________________________________ > > >>> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > >>> To unsubscribe send an email to > > >>> infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > > >>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > >>> List Guidelines: > > >>> https://fedoraproject.org/wiki/Mailing_list_guidelines > > >>> List Archives: > > >>> https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > >> _______________________________________________ > > >> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > >> To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > > >> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > >> List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > > > > > > > > > > > > > > > > > _______________________________________________ > > > infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > > To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > > > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > > List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > > > > > > -- > > Mikolaj Izdebski > > Senior Software Engineer, Red Hat > > IRC: mizdebsk > > _______________________________________________ > > infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > > > > -- > Stephen J Smoogen. -- Stephen J Smoogen. _______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
