On Tue, Jun 07, 2016 at 12:24:13PM -0600, Kevin Fenzi wrote: > On Tue, 7 Jun 2016 14:43:57 +0000 > Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> wrote: > > > Hi, > > > > Since we currently have to deal with a lot of spam accounts, it would > > be very useful for our > > systems, like zodbot and FMN, to not retrieve all of those accounts > > from FAS. > > So, this is just to improve load time? Or memory? Or both? Both I think > > I have just merged a patch for FAS2 to not return inactive accounts by > > default, and I would > > like +1s to push this to production. > > > > The patch is at https://github.com/fedora-infra/fas/pull/161. > > > > Do note that this patch does break the FAS2 API in that it suddenly > > stops returning inactive users. > > Please take this into consideration when sending a +1/-1. > > I'm a bit worried this will cause some confusion as someone will look > and not see an account and try and sign up with it, etc. > > And I know it's going to cause problems with support in #fedora-admin. > The first thing we do when someone comes in with an account problem is > use zodbot to search for them. If they don't show up because they are > inactive it's going to confuse everyone. > > So I am -1 to this for now, but I guess I could be convinced. .fas uses cached info but .fasinfo queries FAS directly iirc, so if someone comes in and provides its FAS username, .fasinfo will return the info regardless of whether .fas would find it. Alternatively, we could patch zodbot to retrieve/cache all the nicks regardless of their status. Pierre
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
