Re: [389-devel] please review coverity fix

Noriko Hosoi <nhosoi@xxxxxxxxxx> · Thu, 01 Aug 2013 12:11:21 -0700



    Mark Reynolds wrote:

    
    I
      added an unnecessary NULL check that caused a coverity error, so I
      removed it:
      

      2328                                           to the poll list */
      

      At conditional (1): "pb->pb_conn" taking the false branch.
      

      CID 13182: Dereference after null check (FORWARD_NULL)Comparing
      "pb->pb_conn" to null implies that "pb->pb_conn" might be
      null.
      

      2329 if(pb->pb_conn &&
      pb->pb_conn->c_opscompleted == 0){
      

    ack

    Thanks, Mark!

    --noriko

    
      Thanks,
      

      Mark
      

      --
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel
    
    
--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel