I added an unnecessary NULL check that caused a coverity error, so I
removed it:
2328 to the poll list */
At conditional (1): "pb->pb_conn" taking the false branch.
CID 13182: Dereference after null check (FORWARD_NULL)Comparing
"pb->pb_conn" to null implies that "pb->pb_conn" might be null.
2329 if(pb->pb_conn && pb->pb_conn->c_opscompleted == 0){
Thanks,
Mark
--
Mark Reynolds
389 Development Team
Red Hat, Inc
mreynolds@xxxxxxxxxx
>From a4daf1a0a65f796878b40b8ebc572082a1101f3b Mon Sep 17 00:00:00 2001
From: Mark Reynolds <mreynolds@xxxxxxxxxx>
Date: Thu, 1 Aug 2013 15:05:16 -0400
Subject: [PATCH] Ticket47426 - Coverity issue with last commit(move compute_idletimeout out of handle_pr_read_ready)
I had added a NULL check trying to avoid a coverity error, but pb->pb_conn can not be
NULL when it gets to this code. Removed NULL check.
https://fedorahosted.org/389/ticket/47426
Reviewed by: ?
---
ldap/servers/slapd/connection.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ldap/servers/slapd/connection.c b/ldap/servers/slapd/connection.c
index 6431874..f5fa51b 100644
--- a/ldap/servers/slapd/connection.c
+++ b/ldap/servers/slapd/connection.c
@@ -2326,7 +2326,7 @@ connection_threadmain()
in connection_activity when the conn is added to the
work queue, setup_pr_read_pds won't add the connection prfd
to the poll list */
- if(pb->pb_conn && pb->pb_conn->c_opscompleted == 0){
+ if(pb->pb_conn->c_opscompleted == 0){
/*
* We have a new connection, set the anonymous reslimit idletimeout
* if applicable.
--
1.7.1
--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel
