[perl-Module-Implementation] Minor spec clean-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



commit c0228b7d60ea9dd1f783908273e4d23777891cd8
Author: Paul Howarth <paul@xxxxxxxxxxxx>
Date:   Thu Jun 7 12:12:47 2012 +0100

    Minor spec clean-up
    
    - Drop %defattr, redundant since rpm 4.4
    - Don't need to remove empty directories from buildroot
    - Add commentary regarding conditionalized buildreqs

 perl-Module-Implementation.spec |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)
---
diff --git a/perl-Module-Implementation.spec b/perl-Module-Implementation.spec
index 7a8ad0a..d557300 100644
--- a/perl-Module-Implementation.spec
+++ b/perl-Module-Implementation.spec
@@ -9,7 +9,7 @@
 
 Name:		perl-Module-Implementation
 Version:	0.06
-Release:	2%{?dist}
+Release:	3%{?dist}
 Summary:	Loads one of several alternate underlying implementations for a module
 Group:		Development/Libraries
 License:	Artistic 2.0
@@ -48,8 +48,11 @@ BuildRequires:	perl(Test::EOL)
 BuildRequires:	perl(Test::NoTabs)
 BuildRequires:	perl(Test::Pod)
 BuildRequires:	perl(Test::Spelling)
+# Can't use aspell-en from EPEL-7 as BR: for RHEL-7 package so skip the spell
+# check test there; test would fail rather than skip without Test::Spelling so
+# we need to keep that as a buildreq
 %if 0%{?rhel} < 7
-BuildRequires:  aspell-en
+BuildRequires:	aspell-en
 %endif
 # ===================================================================
 # Runtime requirements
@@ -84,7 +87,6 @@ make %{?_smp_mflags}
 rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
 %{_fixperms} %{buildroot}
 
 %check
@@ -94,14 +96,18 @@ make test RELEASE_TESTING=1
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc Changes LICENSE README
 %{perl_vendorlib}/Module/
 %{_mandir}/man3/Module::Implementation.3pm*
 
 %changelog
+* Thu Jun  7 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.06-3
+- Drop %%defattr, redundant since rpm 4.4
+- Don't need to remove empty directories from buildroot
+- Add commentary regarding conditionalized buildreqs
+
 * Thu Jun  7 2012 Marcela Mašláňová <mmaslano@xxxxxxxxxx> - 0.06-2
-- conditionalize aspell dependency
+- Conditionalize aspell-en dependency
 
 * Sun Feb 12 2012 Paul Howarth <paul@xxxxxxxxxxxx> - 0.06-1
 - Update to 0.06
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel



[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Legacy Announce]     [Fedora PHP Devel]     [Kernel Devel]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Big List of Linux Books]     [Gimp]     [Yosemite Information]
  Powered by Linux