Since the truth package landed in rawhide a few days ago now (and I have been busy moving cross Sweden) I thought it might be time to revisit the guava change. I have updated the https://github.com/nresare/fedora-guava/tree/testlib-tests branch with your feedback.
Somewhat troubling, trying to create a koji scratch build (http://koji.fedoraproject.org/koji/taskinfo?taskID=10133700) was really slow and now seem to have stalled indefinitely since a thread died in TreeMultisetTest with OutOfMemoryError. I guess the build server farm is somewhat overloaded at the moment, but it is unfortunate if unit tests die when low on memory.
I hope someone else has some insight into this as the whole build infrastructure is pretty opaque to me at the moment.
n
On Tue, Jun 9, 2015 at 3:40 PM, Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> wrote:
On 06/09/2015 03:27 PM, Noa Resare wrote:
> Thank you for all the useful feedback. In the latest few days, I have
> looked quite closely at the packages I prepared and concluded that the
> guava change to enable testlib and unit tests can be made much smaller if
> the caliper dependency is simply disabled.
>
> The dependency is not used by the default maven build (caliper is a
> benchmarking framework and benchmarking, while useful, is not part of the
> code shipping or testing)
>
> This means that we are down to a single extra dependency to be able to
> enable guava testing, the truth package.
That's nice.
> I have submitted a review request and I'm looking for sponsors:
> https://bugzilla.redhat.com/show_bug.cgi?id=1229704
I've taken the review.
--
Mikolaj Izdebski
Software Engineer, Red Hat
IRC: mizdebsk
--
java-devel mailing list
java-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/java-devel
Spotify Free Software ombudsman. I/O Tribe.
-- java-devel mailing list java-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/java-devel
