Daniel P. Berrange wrote: > On Wed, Jul 09, 2008 at 11:21:39AM -0400, Cole Robinson wrote: >> In virt-install I added a boolean --sound option which defaults >> to adding the es1370 device, which seems to be sufficient for >> most modern distros. I'm not sure if this option should be >> adjusted to allow the user to specify sound models but it seems >> like added complexity for an undetermined use case. > >> @@ -405,6 +406,7 @@ >> cli.get_memory(options.memory, guest) >> cli.get_uuid(options.uuid, guest) >> cli.get_vcpus(options.vcpus, options.check_cpu, guest, conn) >> + cli.get_sound(options.sound, guest) > > You want to skip this unless explicitly 'hvm' - paravirt Xen and > container based virt have no sound support. > > Daniel Ah good call, I'll fix when I apply. Thanks, Cole _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
