On Fri, Nov 30, 2007 at 11:13:03AM -0500, Mark Johnson wrote: > from conversation on #xen.... current Solaris virt-install patches attached. > > Disclaimers :-) > This are informational only (e.g. not proposing they be applied).. > They still need cleanup etc.. These patches are what are in the > current solaris builds. > We are currently still working on the lastest version of virt-install. I applied the MAC address patch since that was trivial. The xm console stuff we already fixed. Likewise the vncviewer changes should disappear when you re-base, since we now use virt-viewer. The other changes all basically look sane. Some of them are actually needed on Linux too - eg switching to use capabilities API instead of touching /proc or /sys. I'd recommend moving the SunOS_installxargs method to the OSDistro.py file in the SolarisOSDistro class just to keep it all in one place. Simiarly I'd prefer to see the loopback mount/unmount stuff kept in the ImageFetcher module directly rather than in util.py Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools