Daniel P. Berrange wrote:
On Thu, Nov 22, 2007 at 11:06:58PM -0800, Robert Nelson wrote:
Daniel P. Berrange wrote:
In the virtinst/FullVirtGuest.py class, there is already a bunch of
OS specific metadata, eg what of mouse to use, apic/acpi/pae settings,
whether the installer is multi-stage reboots (eg Windows). I'd recommend
moving this metadata into virtinst/DistroManager and have a bunch of
methods in that module for querying distro specific metadata, from the
Installer class.
Dan.
I spent some time reworking the virtinst code to support OpenSolaris and
make it much easier to support additional OSes. I've attached the patch
file to get some feedback on the work so far.
Thanks for this. Took me a little while to get to grips with it, but I
like the resulting structure. I'm going todo a few tests and if it
works I'll commit it to the repo.
BTW, for any large patches in the future, its handy for review if you
do separate patches for re-factoring existing code, vs adding new
capabilities. It would have made it easier to review if the splitting
up of the DistroManager.py file were a simple no-functional-change
refactoring. Also helps people browsing the SCM history in the future
to distinguish the changes. No need to change this existing patch
though, I'll just add as is...
Please hold off on committing this patch. I have an updated and better
version coming shortly. I'll post it as two patches to make the SCM
history more readable. I'll also post it to a new thread.
Unfortunately a bunch for the code from virtinst is duplicated in
virt-manager in the Add Device code. This means either moving it back
to virtinst with the appropriate additional APIs or duplicating work in
virt-manager.
We should make virt-manager call into the virtinst APIs really. virtinst
is intended as the library for virt-manager to get all OS install/setup
logic from.
If you don't mind, I'll put together a prototype of this for review.
Regards,
Dan.
|
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
