Re: connecting github to the email lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 30, 2015, at 11:43 AM, David Shea wrote:
> On 01/30/2015 11:19 AM, Brian C. Lane wrote:

> Well, one fun thing that clumens found with pykickstart patches is that 
> if you have a pull request with a bunch of line comments on it, and then 
> the contributor does a push --force to update the patch, all those line 
> comments are lost. 

Yeah, this is really broken IMO.  The "solution" we've used some times
on is to push additional '[fixup]' commits, and only squash before merging.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list




[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux