Hi All,
This patch modifies the requirement of ":" (colon) to be present compulsorily in iSCSI Initiator name in Anaconda installer while adding an iSCSI Disk.
Currently while adding an iSCSI Initiator name during installation using Anaconda installer, the iSCSI Initiator name should be containing "." (dot) and ":" (colon) in the iSCSI Qualified Name (IQN) format.
(Ex: iqn.2001-04.com.example:diskarrays-sn-a8675309 ) Without both of them the "Start Discovery" button remains greyed out and the user is unable to discover/add iSCSI target.
However, according to RFC 3720 and RFC 3721, the IQN names may contain a colon optionally.
Hence presence of colon in IQN names should not be considered as a mandatory condition while checking the validity of IQN Initiator name.
This can also be applied for EUI format of iSCSI Naming where only dots will be present.
Requesting review and inclusion to git repo.
****************************************************************************************
>From bbbcbb16a5a8979ae8deaa49cbfb594701960c6e Mon Sep 17 00:00:00 2001
From: Sujith Pandel <sujithpshankar@xxxxxxxxx>
Date: Wed, 7 Jan 2015 05:41:34 -0500
Subject: [PATCH] Make colon optional while adding iSCSI Initiator Name
Signed-off-by: Sujith Pandel <sujithpshankar@xxxxxxxxx>
---
pyanaconda/ui/gui/spokes/advstorage/iscsi.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
index 90a1444..5d2f286 100644
--- a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
+++ b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
@@ -302,7 +302,8 @@ class ISCSIDialog(GUIObject):
text = widget.get_text()
stripped = text.strip()
- return "." in stripped and ":" in stripped
+ #iSCSI Naming Standards: RFC 3720 and RFC 3721
+ return "." in stripped
def on_discover_field_changed(self, *args):
# Make up a credentials object so we can test if it's valid.
--
1.9.3
****************************************************************************************
Thanks & Regards,
Sujith Pandel
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
