On 10/15/2013 06:20 PM, David Lehman wrote:
On Tue, 2013-10-15 at 13:35 -0400, Gene Czarcinski wrote:
Could someone explain just what to process is for patches submitted for
anaconda and related packages.
There is the patch mailing list but that seems to be something of a
black hole. Many of the submitted patch messages are not even in
plain-text (mbox) format so that they can be used as input to patch/git
without a lot of manual effort. This is very different from other
projects that I have worked on.
Almost all of the patches on the list are (and should be) generated by
git-format-patch, so they work fine with git-am.
OK, having done some research and looked at various emails, I think I
now understand.
First of all, git format-patch needs to be able to handle more than just
7bit characters and it does with the --binary resulting in utf-8 and
Transfer-Encoding: 8bit. Now most mailing lists supporting patch
sumissions leave it at that ... but not anaconda-patches. If an email
arrives which is 7bit, it is left as if. However, any email arriving
which has TransferEncoding: 8bit specified is converted to
TranferEncoding: base64 with the text also converted/
Yes, if you save this email file, then it can be successfully used by
git-am. However, it cannot be used by git-apply which is a different
situation than is done for other projects/mailing lists.
I also notice that the anaconda-patches mailing list is not threaded
unlike most other mailing lists.
I am sure this is all done for good reasons. It was just that it was
unexpected by me.
Gene
Just how does one go about getting a patch accepted so that it gets
added to the anaconda, pykickstart or python-blivet repositories?
With respect to BTRFS, I am simply trying to get things so that
anaconda-kickstart has basic functionality. The two areas my recently
submitted patches address are currently supported by the GUI.
There is one bug there, and I told you some time ago (in the bug report)
that I had a patch for it. Aside from that, the btrfs kickstart
functionality is on par with that of lvm.
Having said all that, I do apologize for taking so long to send the
patch in question out for review.
David
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
