On Fri, Aug 10, 2012 at 04:52:34AM -0400, Martin Sivak wrote: > Hi, > > > Could you add all tests into the top-level tests/ directory? I don't > > really like mixing tests and code into the same structure. > > This is for longer discussion. I don't like navigating separate (and different) directory structure to find the file with the proper unittest to modify. > > And since nobody was maintaining the tests we did with tmlcoch, I think having the tests for file.py in file_test.py makes people realize they should take a look at that file when the code is updated or moved somewhere. > > Test execution is handled by python-nose and it doesn't care about where the file is. On the other hand, importing the file under test is much much easier this way (it won't import all the package inits along the way, which is good - unittests are about unit isolation). > > Packaging is still OK as we can do rm *_test.py* in the install phase. > > David asked me to take care about the unittesting infrastructure and this is my proposal. I like tests to be in their own directory tree. They make the core source directories harder to read when you add _test.py to every file that's already in there and I think it also helps keep some separation between tests and the code. I think the most useful thing we can do (other than better upkeep of the tests) is integration of the test run into the build process, during make release and rpm's %check section. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgphTsiDfsQDo.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
