Incidentally, my original patch was incomplete. I completely missed the part where welcome.py will still change your language via locale.setlocale. Clearly, more needs to be done. > But I feel like the apply() methods should be independent of the UI, > shouldn't they? In theory, applying the changes requested by ksdata (at > least for simple things like time zone) would be the same procedure > regardless of which UI requests those changes. They are and aren't independent of the UI. It's likely the code could be shared at least to some degree across interfaces, yes. It also needs to be written in such a way that it can happen immediately. That's what this is all about - some spokes have to change things in the running environment right away. > Maybe apply() should be a method on the Handler object(s) instead? Hmm, that's interesting. We've already got execute methods in kickstart.py. Those could just be beefed up, and then the apply method on a spoke could just call the correct execute method. I still like having apply on a spoke so it's easy to centrally set things when the spoke is done running. It occurs to me as I type all of this that the current behavior of the welcome spoke is to change the language as you flip through the list, which is completely contrary to everything else we're talking about here. Joy. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
