On Wed, 2012-06-20 at 15:47 -0400, Chris Lumens wrote: > The apply methods have ended up trying to do two separate tasks at once: > setting values into ksdata, and applying changes (like keyboard or language) > to the running system. This works okay for system installation, but is not > good for testing or for future use of the UI as a kickstart generator. > > Thus, this patch starts splitting the current apply methods out into two > task-specific methods. save methods will write values into the ksdata and > can optionally do stuff like download temporary files. These methods are > mandatory. apply methods will make permanent changes. These methods are > optional, as not every spoke will need to do this. I like the idea of each spoke having a save() method that writes changes to the ksdata object. But I feel like the apply() methods should be independent of the UI, shouldn't they? In theory, applying the changes requested by ksdata (at least for simple things like time zone) would be the same procedure regardless of which UI requests those changes. Maybe apply() should be a method on the Handler object(s) instead? -w _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
