Re: [newui] [PATCH] Sync time with a working NTP server when NTP is turned on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-06-07 at 11:04 -0700, Brian C. Lane wrote:
> On Thu, Jun 07, 2012 at 04:37:00PM +0200, Vratislav Podzimek wrote:
> > chronyd doesn't change the time immediately because it wants to
> > prevent time leaps. However this way it may look like if NTP was
> > not running at all, so we need a manual sync first.
> 
> Isn't there a way to do this with chronyc? I see the makestep command,
> but can't get it to work (501 Not authorised).
I got this too. You need to authorise first by entering password stored
it the /etc/chronyd.keys file. However I don't see any advantage in
using chronyc here. rdate is fast, easy to use and it's exit code tells
us all we need to know about the sync.

> 
> > +    thread_name = "AnaSyncTime_%s" % server
> > +    if threadMgr.get(thread_name):
> > +        #syncing with the same server running
> > +        return
> 
> I think this means that we could have multiple threads running, all
> trying to sync to different servers. That doesn't really seem like a
> good idea, does it?
Why not? I think that the ntp module itself shouldn't force something
like that. If somebody for example runs one_time_sync_async with a
non-working server and then runs it again with a working one, the
expected behaviour is that system time gets synced. However, running
multiple syncs to one server doesn't make much sense. Moreover this way
there doesn't have to be any counter ensuring the uniqueness of the
threads' names.

> 
> > -                if self._config_dialog.working_server is None:
> > +
> > +                working_server = self._config_dialog.working_server 
> 
> There's a trailing space on this line ^^^
Good catch, thanks.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux