On Thu, 2012-06-07 at 10:14 -0700, Brian C. Lane wrote:
> On Thu, Jun 07, 2012 at 03:18:26PM +0200, Vratislav Podzimek wrote:
> > +class F18_Timezone(FC6_Timezone):
> > + def __init__(self, writePriority=0, *args, **kwargs):
> > + FC6_Timezone.__init__(self, writePriority, *args, **kwargs)
> > + self.op = self._getParser()
> > + self.ntp = kwargs.get("ntp", False)
>
> Shouldn't that be True?
>
> > + self.ntp_servers = kwargs.get("ntp_servers", set())
> > +
> > + def __str__(self):
> > + retval = FC6_Timezone.__str__(self)
> > +
> > + if self.ntp:
> > + retval += "--ntp"
> > +
> > + return retval
> > +
> > + def _getParser(self):
> > + op = FC6_Timezone._getParser(self)
> > + op.add_option("--nontp", dest="nontp", action="store_true", default=False)
>
> And hook this up to "ntp" and make the action store_false,
> default=True then you don't end up with one variable instead of 2.
Yeah, I forgot to commit all changes from --ntp (which was my first
version) to --nontp, thanks. I will fix these before pushing.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
