Re: [PATCH f17-branch] dracut parse-kickstart: don't write empty "nameserver="

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 04, 2012 at 01:47:27PM -0400, Will Woods wrote:
> This can actually cause some problems because "getarg nameserver" will
> return "1" for the argument "nameserver=", which means you end up with
> DNS1=1 in your ifcfg, which is obviously wrong.
> ---
>  dracut/parse-kickstart |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/dracut/parse-kickstart b/dracut/parse-kickstart
> index 0c81108..aa4e0e8 100755
> --- a/dracut/parse-kickstart
> +++ b/dracut/parse-kickstart
> @@ -189,7 +189,8 @@ def ksnet_to_dracut(args, lineno, net, bootdev=False):
>          line.append("ip=%s" % ip)
>  
>      for ns in net.nameserver.split(","):
> -        line.append("nameserver=%s" % ns)
> +        if ns:
> +            line.append("nameserver=%s" % ns)
>  
>      if net.mtu:
>          # XXX FIXME: dracut doesn't support mtu= (yet)
> -- 
> 1.7.7.6

Ack

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpJ20GCi4hGN.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux