Re: [PATCH f17-branch] dracut: fix "repo=cdrom" (also kickstart with "cdrom")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 04, 2012 at 01:33:45PM -0400, Will Woods wrote:
> The replacement hack for splitsep wasn't detecting the case where the
> repo is just "cdrom" - no ":PATH" at the end - and trying to remove the
> "cdrom:" from the front of "cdrom", which doesn't work.
> 
> In that case, we'll end up with $rest = $repo, so check for that, and
> set rest="".
> ---
>  dracut/parse-anaconda-repo.sh |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/dracut/parse-anaconda-repo.sh b/dracut/parse-anaconda-repo.sh
> index 1e23c36..59bf7b5 100755
> --- a/dracut/parse-anaconda-repo.sh
> +++ b/dracut/parse-anaconda-repo.sh
> @@ -13,7 +13,8 @@ arg="repo"
>  
>  if [ -n "$repo" ]; then
>      #splitsep ":" "$repo" repotype rest # FIXME: splitsep is buggy
> -    repotype=${repo%%:*}; rest=${repo#$repotype:}
> +    repotype=${repo%%:*}
> +    rest=${repo#$repotype:}; [ "$rest" = "$repo" ] && rest=""
>      case "$repotype" in
>          http|https|ftp|nfs|nfs4|nfsiso)
>              set_neednet; root="anaconda-net:$repo" ;;
> -- 
> 1.7.7.6

Ack.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgphQ_3l5EMsf.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux