Re: [PATCH 04/10] Write out storage configuration as part of turnOnFilesystems.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-05-02 at 15:43 -0400, Chris Lumens wrote:
> > @@ -283,15 +282,9 @@ def writeEscrowPackets(anaconda):
> >              device.format.escrow(ROOT_PATH + "/root",
> >                                   backupPassphrase)
> >  
> > -        wait_win.pop()
> >      except (IOError, RuntimeError) as e:
> > -        wait_win.pop()
> > -        anaconda.intf.messageWindow(_("Error"),
> > -                                    _("Error storing an encryption key: "
> > -                                      "%s\n") % str(e), type="custom",
> > -                                    custom_icon="error",
> > -                                    custom_buttons=[_("_Exit installer")])
> > -        sys.exit(1)
> > +        # TODO: real error handling
> > +        log.error("failed to store encryption key: %s" % e)
> >  
> >      log.debug("escrow: writeEscrowPackets done")
> >  
> 
> Are you thinking about just using another exception class here like
> everywhere else, or doing something different?

Probably the same as everywhere else: instantiate an Exception subclass,
run the error handler, do what it says.

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux