Re: [master] Avoid final hang if no reboot action is specified in kickstart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> First I was thinking:
> 
> --- a/pykickstart/commands/reboot.py
> +++ b/pykickstart/commands/reboot.py
> @@ -28,7 +28,7 @@ class FC3_Reboot(KickstartCommand):
> 
>      def __init__(self, writePriority=0, *args, **kwargs):
>          KickstartCommand.__init__(self, writePriority, *args, **kwargs)
> -        self.action = kwargs.get("action", None)
> +        self.action = kwargs.get("action", KS_REBOOT)
> 
>      def __str__(self):
>          retval = KickstartCommand.__str__(self)
> 
> But then the next kickstart we would spew would have "reboot" and
> that means the final screen is not displayed and the system is
> directly rebooted because step "complete" is skipped (i.e. a
> different behavior). So that would break idempotence.

Yep, that makes sense.  Push it.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux