On 05/17/2011 12:04 AM, Brian C. Lane wrote:
On Mon, May 16, 2011 at 01:45:59PM +0200, Ales Kozumplik wrote:
Hello,
A patchset finishing the feature
https://fedoraproject.org/wiki/Anaconda/Features/Rework_dispatch
follows. Take a look at
https://github.com/akozumpl/anaconda/commits/dispatch for a more
pleasant browsing.
Overall these changes look pretty good. A few questions and comments:
Does sshd really belong as a step in dispatcher? It seems to me that it
isn't related to anaconda at all other than looking for the flag and
starting it. It really isn't part of the installer itself.
Yes, I think: if it fits the dispatching model then why keep it as
something special in the main file?
Also, image that some installs (image install) for instance will never
want to schedule it while some might schedule it depending on a flag
(sshd, debug..). So the installclass should have a say.
In the Dispatcher object I'd rather see the big list of steps as a
separate method. Think of the case where something wants to modify the
class and use a different list of steps. Having them all set in init
makes it harder to do something like that.
Will do that.
Related to that, why is _add_step prefixed with '_'? I could see cases
where either a subclass or something using the class would want to add
steps.
I'll make it public.
Ales
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
