self.anaconda.bootloader.drive_order = self.driveorder - self.anaconda.ksdata.permanentSkipSteps.extend(["upgbootloader", "bootloader"]) + map(lambda step: self.anaconda.dispatch.skipStep(step, permanent=1), + ["upgbootloader", "bootloader"])Careful here - note above that bootloader is added to showSteps, which gets processed after skipSteps in the setSteps method. Because of how this Bootloader class is arranged, you're going to have to guard that last map from ever happening, or the bootloader step will get skipped when it shouldn't be.
What a catch, thanks! I am thinking about it and if the lists are used and then processed at one point it also orders all the skips before all the unskips across all the kickstart commands, not just per command. So in the new patch I sent I am using the lists again and then process them all at once after the kickstart execution step.
+def doSshd(anaconda): + if flags.sshd: + # we need to have a libuser.conf that points to the installer root for + # sshpw, but after that we start sshd, we need one that points to the + # install target. + luserConf = users.createLuserConf(instPath="") + handleSshPw(anaconda) + startSsh() + del(os.environ["LIBUSER_CONF"]) + else: + log.info("sshd: not enabled, skipping.") + + users.createLuserConf(anaconda.rootPath)I'd love to see all this ssh stuff move to using systemd. Perhaps the service file doesn't need to be enabled by default (given all the configuation we do), but we could at least use systemctl to have it started.
Yeah, me too and it is on my to do list, but for a separate job (where I'll also try to tackle X server and metacity startup). Also see https://bugzilla.redhat.com/show_bug.cgi?id=697698. Perhaps for sshd we will be able to use the system systemd config (I do not think that will be possible for the X server though).
Ales _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
