On Thu, 2011-01-13 at 13:17 -0500, Chris Lumens wrote: > > I was considering merging this to mount code, but I decided to abstract the options=r?,remount from the high level logic. I would have to add remount= argument to the mount call as we pass the remount option to isys in this form. > > > > This code also behaves more like unmount call (checking for mounted and existing filesystem first). On the other hand there is a significant part common with the mount call too, especially the SElinux handling. > > Unless dlehman strenuously objects, I guess it's okay. But I can just > see us having to add more duplication should the mount method ever need > to get more complicated. I don't like it, but for now this will do. If people are okay with patches to modularize device pre/post setup/teardown/create/destroy I can try to do the equivalent for the formats. Dave _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
