Re: [master 4/6] logging: simplify stdout logging in execWithCallback().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/20/2010 08:36 PM, Brian C. Lane wrote:

I like that. One question though -- what about when an IOError != 4 is
raised? We will lose all of the output. This appears to be the case for
stderr output in the existing code as well.

I'm not sure how important that is -- I don't know exactly what would
raise IOError != 4 so maybe it isn't really an issue.

That's a good catch. errno 4 is an interrupted system call, so in that case we just go through the loop again. For the errno != 4 cases I'll move the log printing statements inside of the handler.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux