Re: [PATCH] cleanup booty x86 flag.serial handling (#589773)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 05/10/2010 05:55 PM, Brian C. Lane wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/10/2010 05:28 AM, Hans de Goede wrote:
Bug 589773 is caused by booty's x86 flag.serial handling not setting
self.serial at all, when serial is present on the cmdline, but no
console= argument it present and the system is not ia64.

Looking closer at the code I also noticed that it will try to
access the options list at index 1, even though it is empty, when
console=ttyS0 is passed rather then console=ttyS0,...

All in all the code was rather messy, so this patch rewrites it to
better readable, hopefully obviously correct code.
---


+            if self.serialOptions:
+                self.args.append("console=%s,%s" %(self.serialDevice,
+                                                   self.serialOptions))
              else:
+                self.args.append("console=%s,%s" % self.serialDevice)

I think you meant:

self.args.append("console=%s" % self.serialDevice)

with no serial options.


Ah yes, good one.

Thanks,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux