-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/10/2010 05:28 AM, Hans de Goede wrote:
> Bug 589773 is caused by booty's x86 flag.serial handling not setting
> self.serial at all, when serial is present on the cmdline, but no
> console= argument it present and the system is not ia64.
>
> Looking closer at the code I also noticed that it will try to
> access the options list at index 1, even though it is empty, when
> console=ttyS0 is passed rather then console=ttyS0,...
>
> All in all the code was rather messy, so this patch rewrites it to
> better readable, hopefully obviously correct code.
> ---
> + if self.serialOptions:
> + self.args.append("console=%s,%s" %(self.serialDevice,
> + self.serialOptions))
> else:
> + self.args.append("console=%s,%s" % self.serialDevice)
I think you meant:
self.args.append("console=%s" % self.serialDevice)
with no serial options.
Other than that, looks good to me.
- --
Brian C. Lane <bcl@xxxxxxxxxx>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQEVAwUBS+gsfhF+jBaO/jp/AQK98Af/cC3Cw2fkObfRP68J22LJSLqp8U27Bl/v
JUyA7pVFdSS0D6aov6G8GoubRyqKhqLpT1QSJ2UrQN8ACU3cneJTwTxmqf4W/2P/
rtQyQzgQSDfRS0/52DWA4iHng9g5Smzqrka9CItj/eaZoAyorfdy93SlSitqLbPB
PYq+78D19NLY7UlNsPFu1ud2ZhYKjLbsCPO16IwyjwMdR2DBpKYqwFgjt30hOv4E
bYBrC1ozObVZaX2hVC7iT4mQgKVEzS+wsavkWeqqjOMEcnUwpr+BQwB8Hx/KUbI9
XVDaeg+n7ba4jSqTF1pDng/DuJ1WWgpoose3l6H+EsCZowKmvpmIqw==
=nPKn
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
