Brian C. Lane wrote:
Is there a better way to do this than to do a series of patches that modify earlier patches? I know part of my difficulty is unfamiliarity with the code, but I expect that it makes reviewing things, especially ones as big as this, hard for everyone. I actually ran out of steam about half way through the patchset.
I tried really hard to split the whole change to patches of successive steps I sent (squashing of lots of partial patches, fixes, changes, etc... and then using add -i). This is the best I was able to come up with, I hoped that it was the way that would make understanding of the changes easier. So generally the patches are not (and perhaps can't be) independent and should be read successively. Can you be more specific about patches (or hunks) that modify earlier patches? I am not sure that I get what you mean. Perhaps patches 12-17? For example enableNetwork and some other functions are updated in successive patches - they are adding features (12, 14, 16, 17) for which I am asking ack in each patch. Some (13, 15) are simple fixes that should have been squashed into earlier patch. Some are fixes I am not sure about so I want ack (18, 19, 20, 21, 22) I really appreciate your review, and I am ready to answer all your questions or go into detail. Radek _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
