Re: [PATCH 0/2] Take 2 of Remove stderr prints from isomd5sum (#576251)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/25/2010 04:04 AM, Radek Vykydal wrote:
> Brian C. Lane wrote:
>> I've applied my patches on Radek's changes, and changed my mind about
>> returning multiple exit codes. Since we don't exit with a code for
>> each possible failure I don't see any reason to complicate things with
>> one for
>> failure to find the file.
>>
>> I've also moved the rc result string printing into a separate function
>> so it
>> can be called from 2 places before the exit.
>>
>>   
> 
> Both patches look good to me.
> 
> I will add handling of your new return value of mediaCheckFile
> into anaconda with attached patch (will be updated with symbolic
> values for return values) together with anaconda patches for my changes
> of isomd5sum.
> 

Looks good, I've pushed my changes to master.

Brian

- -- 
Brian C. Lane <bcl@xxxxxxxxxx>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBS6uKfBF+jBaO/jp/AQLXjggAhxxRTMFLgrZYUUWHabMgFLKR9l9gEMJ8
86zjHa71QOs/NZMfZwiuHNGgHBUXlEvMVIC9QFh0J6IA9Bi+5AwNwcD4L+iCmFNA
/Y6bLBVmXDisP4Gf6yPG7Hrphg1QdC1NddSKVe/l/ypnqiDB/3cq1hpXc2D1BZ5u
T9IcHjm2tooyxTFcFqP7onEv2jbu7OGff9LwpNwHc2S3JMVQcNLh7ZdH2ILdPAqP
p4rAhrzMT763Jgi9LSokIXbSAmIXl4bVMyPRZ8R3UvDf9QhGkfV7o3JOj3Lg2NgH
CzTQEDZZ19/3dxerngbSnb7FyvDnuf/BpYbVfgvFurqpt65m6T7KQg==
=v2JJ
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux