Brian C. Lane wrote:
I've applied my patches on Radek's changes, and changed my mind about
returning multiple exit codes. Since we don't exit with a code for each
possible failure I don't see any reason to complicate things with one for
failure to find the file.
I've also moved the rc result string printing into a separate function so it
can be called from 2 places before the exit.
Both patches look good to me.
I will add handling of your new return value of mediaCheckFile
into anaconda with attached patch (will be updated with symbolic
values for return values) together with anaconda patches for my changes
of isomd5sum.
Radek
>From d352d2c25434feb8f7bc0ec2eb1c1c6e3bb6de91 Mon Sep 17 00:00:00 2001
From: Radek Vykydal <rvykydal@xxxxxxxxxx>
Date: Thu, 25 Mar 2010 11:44:46 +0100
Subject: [PATCH] Add new return code check for isomd5sum's mediaCheckFile.
Related to #576251.
---
loader/mediacheck.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/loader/mediacheck.c b/loader/mediacheck.c
index ee5a794..b8bb674 100644
--- a/loader/mediacheck.c
+++ b/loader/mediacheck.c
@@ -88,6 +88,10 @@ int doMediaCheck(char *file, char *descr) {
"primary volume descriptor. This probably "
"means the disc was created without adding the "
"checksum."));
+ } else if (rc == -2) {
+ logMessage(WARNING, "mediacheck: %s (%s) open failed", file, descr);
+ newtWinMessage(_("Error"), _("OK"),
+ _("Unable to open disc image."));
} else if (rc == 0) {
logMessage(ERROR, "mediacheck: %s (%s) FAILED", file, descr);
newtWinMessage(_("Error"), _("OK"),
--
1.6.0.6
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
