Re: [PATCH] Before running shouldClear, make sure a real disk was specified (#572523).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-03-12 at 10:16 -0500, Chris Lumens wrote:
> ---
>  kickstart.py |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index 36908d0..9803e3a 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -703,6 +703,9 @@ class PartitionData(commands.partition.F12_PartData):
>              names = [self.disk, "mapper/" + self.disk]
>              for n in names:
>                  disk = devicetree.getDeviceByName(udev_resolve_devspec(n))
> +                if not disk:
> +                    raise KickstartValueError, formatErrorMsg(self.lineno, msg="Specified nonexistent disk %s in partition command" % disk)

The argument to the string format should be %n, not %disk.

Dave

> +
>                  should_clear = shouldClear(disk,
>                                             storage.clearPartType,
>                                             storage.clearPartDisks)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux