Re: [PATCH] Fix displaying error messages on cleanup/remove callback problems (#572893).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack.

On 03/12/2010 04:42 PM, Chris Lumens wrote:
---
  yuminstall.py |    8 +++++++-
  1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/yuminstall.py b/yuminstall.py
index d9c621d..3bd01e5 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -238,6 +238,12 @@ class AnacondaCallback:

              (hdr, rpmloc) = h

+            # If this is a cleanup/remove, then hdr is a string not a header.
+            if isinstance(hdr, rpm.hdr):
+                name = hdr['name']
+            else:
+                name = hdr
+
              # Script errors store whether or not they're fatal in "total".  So,
              # we should only error out for fatal script errors or the cpio and
              # unpack problems.
@@ -246,7 +252,7 @@ class AnacondaCallback:
                      _("A fatal error occurred when installing the %s "
                        "package.  This could indicate errors when reading "
                        "the installation media.  Installation cannot "
-                      "continue.") % hdr['name'],
+                      "continue.") % name,
                      type="custom", custom_icon="error",
                      custom_buttons=[_("_Exit installer")])
                  sys.exit(1)

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux